DanielLeens commented on PR #11893: URL: https://github.com/apache/seatunnel/pull/11893#issuecomment-6359798629
Thanks @nzw921rx for the +1, and thanks @JacobZheng0927 for the patience on this one. To make the next step concrete: the head is still `252204a2f24d` (single commit, unchanged since my approval), so my source-level conclusion is unchanged. The `Build` check on this head is the run from the contributor fork (https://github.com/apache/seatunnel/runs/96304397098), and as I noted earlier the only failing job there is `oracle-cdc-connector-it (8, ubuntu-latest)` (`OracleCDCWithSchemaChangeIT.testOracleCdc2OracleWithSchemaEvolutionCase`, an awaitility timeout), which is in a module this diff does not touch (the PR only changes `JdbcSink` and its unit test). Two practical notes: - A re-run has to be triggered from the fork's Actions tab ("Re-run failed jobs" on the linked workflow run); a reviewer without write access cannot retrigger it from the apache side. - The branch is now about 550 commits behind `dev` and that run is two months old. Syncing the latest `dev` and pushing will start a fresh `Build` on the current base, which is probably more useful than re-running the stale run. Please keep the sync merge-only, with no unrelated changes. I will re-check once a new run exists; if a different job fails I will compare it against the diff rather than assume it is unrelated. Thanks again! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
