88fantasy commented on PR #12388:
URL: https://github.com/apache/seatunnel/pull/12388#issuecomment-6358841885
Thanks @DanielLeens for the detailed review. I have pushed the follow-up to
this Apache SeaTunnel PR at `89e19dd6d85c0e59798828f327997573fc6f017c`.
- Merged community `dev@6b63aca173eb8c056db0b78a87539aec3e4ad1a5` without
conflicts in `80de0d5e9`.
- Added Javadoc to `restoreCoordinator(boolean, Set<TaskGroupLocation>)`,
documenting both parameters and the reconstruction of closed subtasks after
pending-checkpoint cleanup.
- Corrected the `SubPlan#restorePipelineState` comment: FINISHED groups can
also occur during final-checkpoint completion, so the previous "can only be an
idle reader" statement was too strong. This follow-up changes comments only;
the existing classification and runtime behavior are unchanged.
Validation on JDK 11:
- Full-reactor `./mvnw spotless:apply`: passed.
- Full-reactor `./mvnw -q -DskipTests verify`: passed; this command skips
tests.
- `CheckpointCoordinatorTest`, `CheckpointManagerTest`,
`SubPlanRestoreStateTest`, and `StateTransitionCleanupTest`: 36 tests passed,
with zero failures, errors, or skips, using:
```shell
./mvnw -pl seatunnel-engine/seatunnel-engine-server -am \
-Dtest=CheckpointCoordinatorTest,CheckpointManagerTest,SubPlanRestoreStateTest,StateTransitionCleanupTest
\
-Dsurefire.failIfNoSpecifiedTests=false verify
```
The initial `test`-lifecycle invocation failed before executing tests
because config-base's relocated classes are generated during `package`; using
`verify` builds those prerequisites before compiling dependent modules.
The final-checkpoint completion window remains unverified, as does a master
switch while idle-reader closure is still awaiting acknowledgement. No fresh
real-cluster/E2E run was performed for this documentation-only follow-up, and
the earlier manual results in the PR description remain historical.
I also found overlapping PR #12042. This follow-up does not add a second
classification mechanism; the overlap should be coordinated before merging.
CI for the pushed head is tracked in [Build run
39909860824](https://github.com/88fantasy/seatunnel/actions/runs/39909860824),
which currently reports `queued`. Aggregate CI success has not been
established. The local results above are complete independently of that CI
status.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
