DanielLeens commented on PR #11841: URL: https://github.com/apache/seatunnel/pull/11841#issuecomment-6338475913
Thanks @SEZ9 and @JeremyXin. I checked the specific questions against the current head `8ac6d2b4dd7d`: - **F6/F8:** `JobMaster.initCheckPointManager` passes `jobImmutableInformation.isRestoreJob() || restart` at line 344. `CheckpointManager.java:149-160` passes `isRestoreJob` to `CheckpointCoordinator`, not the savepoint-only wire flag. - **F7:** `JobMaster.handleSaveMode` derives the null-safe boolean at 789 and uses that boolean at 796; there is no unconditional dereference of restoreMode after that derivation in this method. - **F3:** the actual CLUSTER call site intentionally skips restore jobs. The comment is already immediately above the guard at `JobMaster.java:276-282`: changing that behavior requires a separate decision and regression test. The overload remains available, but its restore branch is not claimed to execute at that guarded call site. The parser's client-side restore path is separately at `MultipleTableJobConfigParser.java:897-900`. - **F1/F2/F5:** the committed test entry points are `JobImmutableInformationCompatibilityTest.shouldReadLegacyPayload`, `restoreModeShouldMatchLegacySavepointFlag`, and `CoordinatorServiceJobCleanupTest.testSubmitHonorsCallerSuppliedSavepointFlag`. - **F4:** the PR description already states that checkpoint restores fail with JobException for the pending-cleanup/existing-metrics cases, and explicitly identifies these as preserved coordinator behavior. These are source-read pointers, not local test execution or a fresh full review. My own source conclusion remains clear; please keep @nzw921rx's historical review separate until they recheck/update it. The required Build is still failed. The LLM fixture correction #12938 and shared template-provider proposal #12895 remain open; no immediate base sync is established as a cure for those failures. Other failed integration stages still need their own clean result, and a write-capable maintainer must finish the review gate. Current status evidence: head `8ac6d2b4dd7d0d75b9a639664a2e02a4201fa23a`, base `dev`, compare `diverged` (ahead 16, behind 10), mergeable state `blocked`. CI references: [current Build check](https://github.com/apache/seatunnel/runs/119093498855), [Run / mysql-cdc-connector-it (11, ubuntu-latest)](https://github.com/JeremyXin/seatunnel/actions/runs/39534487849/job/119108829347), [Run / all-connectors-it-2 (11, ubuntu-latest)](https://github.com/JeremyXin/seatunnel/actions/runs/39534487849/job/119108829457). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
