LeonYoah commented on PR #12912: URL: https://github.com/apache/seatunnel/pull/12912#issuecomment-6331908702
Thanks for the thorough review! Pushed b36c603e (plus a merge of the latest dev): 1. `sslmode` default text: fixed in the option description and EN/ZH docs; there is no more `prefer` claim. The effective default is Debezium's `disable`. 2. Implicit `sslmode` change: URL inheritance is removed. `database.sslmode` is written only when the top-level `sslmode` is explicitly set, and that override of `debezium.database.sslmode` is documented. When unset, the key is untouched, so existing jobs behave exactly as on dev and no incompatible-changes entry is needed. Tests cover unset/debezium/explicit precedence and URL non-inheritance. 3. Scope: kept in one PR, but the description now states the scope (reset fix, `sslmode`/publication options, the `applyAuthoritativeConnectorProperties` hook) and no longer mentions `heartbeat.interval.ms`, which was removed in c4a30185. The unrelated sample and FAQ rewrites are reverted to dev; only docs for the reset fix and the new options remain. 4. Catch-up reconnect: in pre-snapshot catch-up streaming the probe now rethrows without reconnecting (defensive, since SeaTunnel never sets a streaming stopping LSN), with a test. 5. Added the why-comment: `connect()` only reconnects when the connection is null or closed and pgjdbc may not mark a reset connection closed, hence `close()` first; a single retry keeps an unreachable DB failing fast into checkpoint restore. 6. The probe method is package-private with `@VisibleForTesting` and the test calls it directly. Added tests for invalid `sslmode` and `publication.autocreate.mode` values. Locally: unit tests and the full PostgresCDCIT (38/38) pass. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
