fatmanverse commented on PR #12921: URL: https://github.com/apache/seatunnel/pull/12921#issuecomment-6309562743
Thanks @DanielLeens for the review. - **Issue 1:** e528e25 adds a comment to `decodeQueryComponent`. It explains that `UnsupportedEncodingException` cannot occur for UTF-8 and is caught only because the `String` overload declares it. It also explains that `IllegalArgumentException` means a malformed escape such as `%zz`, and that both are rethrown as an `IllegalArgumentException` naming the component, so `ExceptionHandlingFilter` answers 400 instead of 500. A side note: the build baseline is now Java 11, so `URLDecoder.decode(String, Charset)` is available and the catch could go away. I kept this PR to the comment and left that switch out, to keep the change small. I can make the switch here if you prefer. - **Issue 2:** I left `RestApiSubmitJobContentTypeTest` aligned with its sibling REST tests. Cancelling the submitted jobs would be better done for all of them in one follow-up. Verified on JDK 17: spotless is clean and `seatunnel-engine-server` builds. The change is comment-only. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
