DanielLeens commented on issue #12908: URL: https://github.com/apache/seatunnel/issues/12908#issuecomment-6290737569
Classification: A / Connector-V2 File ORC decimal value validation. The silent-loss path is confirmed: `OrcWriteStrategy` passes `HiveDecimal.create(value)` directly to the vector without checking either the conversion result or the target precision/scale result. A value that the declared ORC column cannot represent must not become `NULL` while the job succeeds. #12909 is the focused implementation lane. Please cover both null-producing paths: a value beyond ORC's maximum precision and a value that does not fit the declared precision/scale. The failure should include usable value/column context, while in-range decimal writes must remain unchanged. The compatibility notes are important because affected jobs will now fail explicitly instead of silently losing a value. Please continue review and validation in #12909. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
