DanielLeens commented on PR #12853: URL: https://github.com/apache/seatunnel/pull/12853#issuecomment-6289517934
Update on the CI state for head `dad4e1244`, since my last review was written while the `Build` workflow was still running. The `Build` check on this head is now completed and green. In the fork run for the same SHA I see no failed job: `unit-test` (JDK 11/17 on ubuntu and windows) and the updated-modules integration shards 1 to 5 are green; the log of shard 2 shows the JDBC integration tests (for example `JdbcMysqlTimestampIT`, `JdbcMariaDBIT`, `JdbcAutoGenerateSQLIT`) passing. The dedicated `jdbc-connectors-it-*` shards were skipped by the path filter, so JDBC coverage here comes from the updated-modules shards. I did not find the converter unit tests by name in the logs I sampled, so I cannot separately confirm those from the log text, although `unit-test` as a whole passed. My source-side review found no High, Medium or Low issue, and the head has not changed since. The CI result was the only item I had left open, so there is no remaining blocker on my side. The branch has no merge conflicts. Thanks for the clear compatibility documentation in both languages. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
