DanielLeens commented on PR #12861: URL: https://github.com/apache/seatunnel/pull/12861#issuecomment-6289523745
Update on the CI state for head `3a691729c`, since my last review was written while `Build` was still queued. The `Build` check on this head is now completed and green. In the fork run for the same SHA I see no failed job: `unit-test` (JDK 11/17 on ubuntu and windows), `connector-file-local-it` (11 and 17, which runs the updated Markdown E2E with the new `child_ids` array assertions) and `connector-file-sftp-it` all report success, and the updated-modules shards 1 to 8 are green. That covers the open verification note from my Issue 2 (array assertions through Source -> Metadata -> Sql -> Assert). My source-side review found no code blocker, and nothing has changed on the head since then. The one item still open is the non-blocking Medium documentation suggestion (Issue 1): please add one sentence to the `child_ids` entry in `incompatible-changes.md` (en and zh) stating that top-level blocks under a heading now get that heading as `parent_id` and appear in its `child_ids`. It would be good to include it before merge, but I am not holding the PR for it. The branch has no merge conflicts. Verdict unchanged: Ready to merge. Thanks for the careful follow-up. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
