DanielLeens commented on PR #10945: URL: https://github.com/apache/seatunnel/pull/10945#issuecomment-6286905560
Status update while going through the open first-time-contributor PRs, @officialasishkumar: I tried to sync this branch with `dev` to clear the merge conflict and found that the change has been superseded on `dev`. `DmdbTypeConverter` already recognizes `NVARCHAR2` next to `NCHAR`/`NVARCHAR` through #11684 (`5ffbce52b18`, "Support Dameng national character types in JDBC connector"), and `DmdbTypeConverterTest` already has the matching `nvarchar2(2)` case. Both files of this PR resolve to the `dev` versions with nothing left from this branch, so I did not push anything. This PR can be closed as superseded by #11684 (a committer call); thanks again for the original fix. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
