DanielLeens commented on PR #11634:
URL: https://github.com/apache/seatunnel/pull/11634#issuecomment-6286818112
Pushed `4e85efec792` on top of your branch, @waterWang (merge of the current
`dev` plus one commit) to close Issue 1 from my review:
- `JsonToRowConverters` now applies a catalog default by running the literal
through the same field converter as a JSON value
(`TextNode.valueOf(String.valueOf(default))`), so an `INT` column gets an
`Integer`, a `DECIMAL` column a `BigDecimal`, and so on, instead of the raw DDL
literal being placed into the `SeaTunnelRow`.
-
`JsonRowDataSerDeSchemaTest.testCatalogColumnDefaultsAreTypedWhenFieldMissingOrNull`
covers the `CatalogTable` constructor path for a missing field, an explicit
JSON null and a present value (INT, DECIMAL and STRING defaults); the typed
assertions fail on the previous head, where the String literal was stored as-is.
Your fork did not create a Build run for this push; if none appears, please
start one from the Actions tab ("Run workflow" on Build). Verification run of
the same head on my fork:
https://github.com/DanielLeens/seatunnel/actions?query=branch%3Apr11634-verify-4e85efec792
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
