DanielLeens commented on PR #11076:
URL: https://github.com/apache/seatunnel/pull/11076#issuecomment-6286754414

   Pushed merge commit `65f6f0a4291` (current `dev` into your branch), @HQ018, 
so the PR is no longer conflicting. `dev` picked up #11110, which refactored 
the same loop in `OracleSchema.readTableSchema` into a static 
`resolveTableId(readTableId, requestedTableId, tableMap)` with the 
requested-catalog fallback. I kept `dev`'s structure and ported this PR's three 
additions onto it: `setSessionToPdbIfNeeded` before `readSchema`, the widened 
`getSchemaReadTableFilter`, and the case-insensitive schema/table match inside 
`resolveTableId`, plus the more descriptive "Can't obtain schema" message. Your 
`OracleSchemaTest` (PDB session ordering, catalog-less id, different catalog 
and case, filter-rejected equivalent id) is unchanged and still the coverage 
for these paths. Please double-check the ported logic; the verification run of 
the merged head is at 
https://github.com/DanielLeens/seatunnel/actions?query=branch%3Apr11076-verify-65f6f0a4291


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to