DanielLeens commented on PR #12663:
URL: https://github.com/apache/seatunnel/pull/12663#issuecomment-6285058052
Pushed `1e331e18397` on top of your branch, @SwatiKumari250 (a merge of the
current `dev` plus one Javadoc-only commit) that closes the findings from my
review:
- Finding 1: `getCurrentTableId()` (and the `currentTableId` field comment)
now say the value is the most recent write, sticky after a successful write,
and `null` only before the first row or after a table is quarantined.
- Finding 2: `run()` and the 6-arg constructor now describe ordering as
coming from the FIFO queue drained by the single worker thread, and the monitor
as mutual exclusion with the coordinator's snapshot/flush/close calls.
- Finding 3: the 2-arg constructor is described as the fail-fast variant (no
isolation, no-op handler, no retries); the single-writer fallback is noted as
common to all constructors and the queue is no longer described as owned by the
runnable.
- Finding 4: units (seconds) and the `Math.max(0, ...)` clamping are
documented for both retry parameters; `getThrowable()` now says "the failure
that stopped this worker".
- Finding 5: `run()` mentions the continue-after-quarantine path.
- The `{@link #writeRow(SeaTunnelRow)}` reference to the package-private
method was replaced with `{@code writeRow}`.
No code line changed. Your fork still has GitHub Actions disabled, so please
enable them and push an empty commit so a `Build` run attaches here; I started
a verification run of this head on my fork meanwhile:
https://github.com/DanielLeens/seatunnel/actions?query=branch%3Apr12663-verify-1e331e18397
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
