DanielLeens commented on PR #12651:
URL: https://github.com/apache/seatunnel/pull/12651#issuecomment-6285025054
Pushed `07ee38de6c8` on top of your branch, @SwatiKumari250 (a merge of the
current `dev` plus one commit), which closes finding 1 from my review:
- `AssertFactoryTest` now also validates behavior through
`ConfigValidator.of(ReadonlyConfig.fromMap(...)).validate(factory.optionRule())`,
following the `RedisFactoryTest` pattern: a config without `rules` and a
config with `rules = {}` both throw `OptionValidationException`, while a map
with one `row_rules` entry passes. The existing structural test is kept
unchanged.
Your fork still has GitHub Actions disabled, so no `Build` run can attach to
this PR. Could you please enable Actions in your fork (Actions tab, then enable
workflows) and push an empty commit? In the meantime I started a verification
run of this exact head on my fork:
https://github.com/DanielLeens/seatunnel/actions?query=branch%3Apr12651-verify-07ee38de6c8
The PR description is still the empty template; filling in the purpose and
noting that the factory rule is now the single enforcement point for `rules`
would help the committers.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
