DanielLeens commented on PR #12880: URL: https://github.com/apache/seatunnel/pull/12880#issuecomment-6282877410
Thanks @hutiefang76 for checking the head and for the local test evidence. To clarify the CI state for `26ceb950`: the apache-side `Build` check run is in the `action_required` state, and only `labeler` and `Notify test workflow` have completed. That state normally means the pull request workflow is waiting for a maintainer with write access to approve it, or for the contributor-side run it points to to be able to execute. My account only has review rights, so I cannot approve or dispatch workflows and cannot trigger the checks myself, sorry. What may help on your side: if the fork-side run is needed, enabling Actions for the fork under Settings > Actions > General (the 422 `Actions has been disabled for this repository` message suggests it is currently off) would let the workflow start. Otherwise a maintainer can approve the pending run. The branch is also 8 commits behind `dev`, so please sync it before the re-run so the result is for an up-to-date base. I have no new source-side concern: the aggregation of unsupported columns on the query path and the separate table-metadata path noted in the PR description both match what I traced in my review. My earlier review stands, and the CI result is the only thing still missing. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
