DanielLeens commented on PR #11174: URL: https://github.com/apache/seatunnel/pull/11174#issuecomment-6266718465
Thanks @SEZ9 for the consolidated summary. I re-checked head `31000f5a88dc8d2b505a86a3ad4fae214c431c54` and it is unchanged since my last pass, so I +1 all of F1-F8 as listed there (docs scope, single artifact model, fail-fast validation in the starter, `install` for the second reactor, wiring `SparkCommandArgsTest` / `MultiTableSinkTest` into a lane, making the `spark-4-1-it` lane prove `FakeSpark41IT` ran, and the workflow action versions). One additional blocker that is new since my last comment: the PR is now `DIRTY` against `dev` (compare status `diverged`, 23 ahead / 538 behind), so GitHub reports merge conflicts. Please sync the latest `dev`, resolve the conflicts, and push a new head. That will also give us a fresh `Build` run on which to verify the `spark-4-1-it` lane end to end. Once the new head is up I am happy to do another full pass. Thanks again for sticking with this one, @shangeyao! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
