xinnyuli commented on PR #12726: URL: https://github.com/apache/seatunnel/pull/12726#issuecomment-6260394154
@DanielLeens Thanks for the review. Pushed dc6975b on top of a rebase onto current dev: Issue 1: both Azurite classes now have @DisabledOnOs(OS.WINDOWS) (I actually hit a taken port 10000 locally on Windows), and createIfNotExists() retries for up to 5 seconds before failing with an explicit message. Issue 3: each AzuriteEmulator copy now points at the other. Also added an IMap test that writes past block.size so AzureWriter rolls over, then recovers both segments from a new instance with the writer still open. While writing it I found that the config tests leaked block.size through the shared FileConfiguration.AZURE instance, so the config test now resets it. Issue 2: verifying the jar list against a clean distribution lib/ now; I’ll update the docs and description with the result. No real storage account has been tested yet. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
