fatmanverse opened a new pull request, #12890:
URL: https://github.com/apache/seatunnel/pull/12890
Follow-up to #12800 (#12796). Test only, no production code change.
### Purpose of this pull request
The triage of #12796 asked for "source and sink regression tests proving
documented keys are accepted while an actually unknown key is still rejected".
#12800 has the negative case for the sink only
(`JdbcSinkFactoryTest#testUndeclaredSinkOptionIsUnknownKey`).
This adds the source counterpart,
`JdbcSourceFactoryTest#testUndeclaredSourceOptionIsUnknownKey`: a misspelled
key (`fetch_sise`) is still rejected by `validateUnknownKeys`. It also adds the
DSQL options `access_key_id`, `secret_access_key` and `region`, declared on the
source in #12800, to `testDocumentedSourceOptionsAreNotUnknownKeys`.
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
`./mvnw -pl seatunnel-connectors-v2/connector-jdbc test` on JDK 17: the new
test and the rest of the module pass, except
`JdbcOptionRuleCompletenessTest#testSinkRuleDeclaresAllSinkOptions`, which
already fails on `dev` since #12792 and is fixed by #12875 (#12874).
### Check list
* [ ] If any new Jar binary package adding in your PR, please add License
Notice according
[New License
Guide](https://github.com/apache/seatunnel/blob/dev/docs/en/developer/new-license.md)
* [x] If necessary, please update the documentation to describe the new
feature. https://github.com/apache/seatunnel/tree/dev/docs (not needed)
* [x] If necessary, please update `incompatible-changes.md` to describe the
incompatibility caused by this PR. (not needed)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
