SEZ9 commented on PR #11814: URL: https://github.com/apache/seatunnel/pull/11814#issuecomment-6258895061
Thanks for the follow-up work on this. Before I can sign off I want to verify the earlier points against the actual changes at `131de7f704` rather than the summary, so it would help if you could point me to the specific diffs for each: 1. **F1 – E2E wait strategy**: where the `received new worker register` wait is now applied so that it gates container startup in `FakeSourceToConsoleWithEventReportIT`, rather than being set in `executeExtraCommands`. 2. **F2 / F3 – `close()` behaviour**: the changes that stop the local-buffer flush from running concurrently with a still-running task when the scheduler fails to terminate, cancel in-flight calls, and handle runtime failures other than `HazelcastInstanceNotActiveException`/`IOException` on an interrupted thread. 3. **F4 / F6 – Kotlin stdlib versions**: whether `kotlin-stdlib` and `kotlin-stdlib-common` are now pinned to a single version, and that `known-dependencies.txt` and `seatunnel-dist/release-docs/LICENSE` match what actually resolves in the dist. 4. **F5 – `testRetryAfterHttpFailure`**: the changes that add a timeout to `takeRequest()`, release the request `Buffer`s, and remove the dependency on the scheduler firing immediately given the configured interval. 5. **F7 – redirects**: the line where redirects are disabled on the `OkHttpClient` so configured headers cannot be forwarded to another host. 6. **F8 – Content-Type charset**: whether the reported `Content-Type` stays byte-identical for existing collectors when the configured media type has no charset, or an explicit note of the behavioural change. Once I can confirm each of these in the diff I'll finish the review. <!-- streview-comment:1867 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
