Rishavbhattarai commented on PR #12844: URL: https://github.com/apache/seatunnel/pull/12844#issuecomment-6237809111
Thanks for the review, @DanielLeens. I pushed 7170268. - **Issue 1:** Rebased onto current `dev` (93cd240). The conflicts were in the five registration files you listed. I kept the Intercom entries and added only the Typeform lines. The diff against `dev` for those files is now 10 added lines, all Typeform. - **Issue 3:** Retry exhaustion now throws `HttpConnectorErrorCode.REQUEST_FAILED`. - **Issue 2:** Added a note to the EN and ZH docs that a very large form is read in one uninterrupted pass, so checkpoint triggering waits for it. - **Issue 4:** No change, as you suggested. The 20 unit tests pass locally on JDK 11. I can't run `TypeformIT` locally, so I'll check that its job passes in the fork CI run for this head and report back here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
