goutamadwant opened a new pull request, #12845:
URL: https://github.com/apache/seatunnel/pull/12845

   ### Purpose of this pull request
   
   Related to #11513. Follow-up to #12470.
   
   On 2026-10-10 `engine-k8s-it` failed on 7 PRs during the k3s install. 
`get.k3s.io` served the install script, but the script's lookup of the `stable` 
channel on `update.k3s.io` failed with a TLS error. The script swallows that 
error, uses the literal `stable` as the version, and the hash download fails:
   
   ```
   [INFO]  Finding release for channel stable
   curl: (60) SSL certificate problem: self-signed certificate
   [INFO]  Using stable as release
   [ERROR]  Download failed
   ```
   
   The job then reported a second error: `Upload test reports` (added in 
#12470) runs a local action, but the repository was not checked out yet 
([example](https://github.com/goutamadwant/seatunnel/actions/runs/38091758742/job/114334157499)).
   
   This PR:
   
   - sets `INSTALL_K3S_VERSION: v1.36.5+k3s1` (the current stable) in the 
workflow `env`, so the installer skips the channel lookup in both 
`engine-k8s-it` and the Helm chart job;
   - retries the install up to three times, with `pipefail` so a failed 
download is not piped into `sh` as an empty script;
   - checks out before the install, so the report upload can always run.
   
   **Before:** an `update.k3s.io` outage fails the install, and the report 
upload fails as well.
   **After:** the install does not depend on `update.k3s.io`; a transient 
failure is retried; if all attempts fail the step fails with a clear message 
and the reports are uploaded.
   
   ### Does this PR introduce _any_ user-facing change?
   
   No. CI only. The k3s version is now pinned instead of following the `stable` 
channel; bump `INSTALL_K3S_VERSION` to upgrade.
   
   ### How was this patch tested?
   
   - Ran the real `get.k3s.io` installer in `ubuntu:22.04` with `update.k3s.io` 
blocked:
     - without the pin: `Finding release for channel stable`, `Using stable as 
release`, `Download failed`, exit 1 (same as CI);
     - with the pin: `Using v1.36.5+k3s1 as release`, binary downloaded and 
verified, installed, exit 0.
   - Ran the new install step against a local server: success on the first try; 
one failed request then success (1 retry); every request failing (2 retries, 
then `k3s install failed after 3 attempts`, exit 1).
   - `actionlint`: same pre-existing findings as `dev`, none in the changed 
lines.
   - This PR's own CI runs `engine-k8s-it`, because workflow changes route to 
the full suite.
   
   ### Check list
   
   * [ ] If any new Jar binary package adding in your PR, please add License 
Notice according
     [New License 
Guide](https://github.com/apache/seatunnel/blob/dev/docs/en/developer/new-license.md)
   * [ ] If necessary, please update the documentation to describe the new 
feature. https://github.com/apache/seatunnel/tree/dev/docs
   * [ ] If necessary, please update `incompatible-changes.md` to describe the 
incompatibility caused by this PR.
   * [ ] If you are contributing the connector code, please check that the 
following files are updated:
     1. Update 
[plugin-mapping.properties](https://github.com/apache/seatunnel/blob/dev/plugin-mapping.properties)
 and add new connector information in it
     2. Update the pom file of 
[seatunnel-dist](https://github.com/apache/seatunnel/blob/dev/seatunnel-dist/pom.xml)
     3. Add ci label in 
[label-scope-conf](https://github.com/apache/seatunnel/blob/dev/.github/workflows/labeler/label-scope-conf.yml)
     4. Add e2e testcase in 
[seatunnel-e2e](https://github.com/apache/seatunnel/tree/dev/seatunnel-e2e/seatunnel-connector-v2-e2e/)
     5. Update connector 
[plugin_config](https://github.com/apache/seatunnel/blob/dev/config/plugin_config)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to