DanielLeens commented on PR #11633: URL: https://github.com/apache/seatunnel/pull/11633#issuecomment-6227282182
Thanks for the detailed follow-up and for rerunning only the failed jobs, @li3zhi4! Confirming a few facts on my side, all for head `c93535365ab74a26ae8e7bd7569474722bcf5700` (still the current head, no new commit since my last review). **Source side:** nothing changed from my last review (https://github.com/apache/seatunnel/pull/11633#pullrequestreview-5502269166). I have no source-level blocker and no recommended fix for the JSON `defaultValue` change. **CI side:** I read the logs of the two failed lanes in fork run 38382223265 (attempt 4). Both `all-connectors-it-2` lanes (JDK 11 and JDK 17) fail on the same two cases and nothing else: - `CassandraIT.testCassandra{TestContainer}[4]` (`CassandraIT.java:134`, `expected: <0> but was: <1>`) - `CassandraIT.testCassandraMultiTableSource{TestContainer}[4]` (`CassandraIT.java:144`, same assertion) The Maven failure is `connector-cassandra-e2e: There are test failures`. This PR does not touch the Cassandra connector, its e2e module, or any of its configs (the changed files are the JSON format, `JsonReadStrategy`, `PulsarSource`, the Kafka JSON IT and docs), and `KafkaJsonDefaultValueIT` / the JSON unit tests are not among the failures. So the failure looks unrelated to this diff. This is an inference from the failing test names and the file list; I did not find a root cause for the Cassandra failure itself. **Suggested next step:** the branch is now `diverged` from `dev` (22 ahead, 34 behind). Since the only red lanes are unrelated, please sync the latest `dev` into the branch and then rerun only the failed `all-connectors-it-2` jobs (not the whole Build). If the Cassandra cases still fail on the fresh head, that is a strong signal it is a pre-existing `dev` issue and worth raising separately with the maintainers. As you noted, a write-enabled maintainer still has to re-check the earlier change request and handle approval and merge-queue steps; I am read-only and cannot do that part. Thanks again for sticking with this one! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
