SEZ9 commented on issue #12838: URL: https://github.com/apache/seatunnel/issues/12838#issuecomment-6228950155
Thanks for the clear reproduction. The collision is real by construction (plain delimiter join is not injective), and keeping LEGACY as the default with an opt-in `key_encoding = LENGTH_PREFIXED` avoids breaking existing document IDs. Please align the option name, enum values and encoding format exactly with what is being done for Elasticsearch/OpenSearch in #12704 so users get one consistent behavior across all search sinks. For the PR scope: please add unit tests asserting exact legacy IDs are unchanged (including single-key and multi-key cases), the collision/non-collision pairs from this issue under LENGTH_PREFIXED, and E2E coverage for both Easysearch and Typesense. The EN/ZH docs should include an explicit warning that switching encoding on an existing index/collection changes document identity and requires reindexing. Please also confirm which SeaTunnel version you reproduced this on and whether single-key IDs are passed through unchanged in both connectors today, so the compatibility statement in the docs is accurate. <!-- streview-comment:1819 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
