SEZ9 commented on PR #12460: URL: https://github.com/apache/seatunnel/pull/12460#issuecomment-6228624835
Thanks @nzw921rx. Closing the loop on the one point that was still open from my side, the P1 watch finding. My review of `f29fd7327` confirmed the fix is in the right place: the `ReportingListerWatcher` / `ReportingWatch` wrappers in `InformerPodWatch` route the swallowed `ConnectException` into `handleWatchFailure` on both the `watch()` call and the stream path, so the failure budget actually starts and `stopAndReport -> callback.onWatchError` fires once it is exhausted, with a successful `list()` resetting `firstFailureNanos`. That finding is resolved and is already reflected in my approval, which stands. Nothing further is needed from you on this point. Thanks again for the careful follow-up on this change. <!-- streview-comment:1811 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
