SEZ9 commented on PR #12608: URL: https://github.com/apache/seatunnel/pull/12608#issuecomment-6228495379
@CodeWithPravinMaske thanks for the follow-up, and no worries about the delay — `1d629b844` is visible now. - **F3/F6:** thanks for the correction on the premise. I haven't yet confirmed from the diff that `mergeCatalogTableConfig` leaves nullability untouched, or that the "Read tables without a primary key" section already carries the wording you describe. Could you point me to the relevant lines in this PR so I can close F3? For F6, I'd still like a short entry in the incompatible-changes / release notes, since existing pipelines whose sinks were provisioned around receiving `0` will now receive SQL NULL. If that's already in the PR, a pointer is enough. - **F4:** your comment appears to be cut off right at the start of this point, so I didn't get your answer. Could you repost it? In particular, how the test covers a nullable `table-names-config.primaryKeys` column that is also the table's first unique key, and whether that case now emits NULL. - **F1/F2:** these are still open from my side — I haven't seen anything in the thread addressing the binlog DDL and table-history paths that bypass the nullability restore. Could you describe how the current head handles those? `Build` is green on `1d629b844` (https://github.com/apache/seatunnel/runs/116836428755) and davidzollo has approved; once the points above are answered I don't expect anything else from me. <!-- streview-comment:1808 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
