fatmanverse commented on PR #12802: URL: https://github.com/apache/seatunnel/pull/12802#issuecomment-6207001009
Thanks @DanielLeens for the review and the welcome. 1. Reworded the Javadoc in 0b8670d. It now says a DECIMAL is written as a number cell when it round-trips through a double, that is when `Double.toString(double)` equals the value, which is what the code checks. 2. I left the `(BigDecimal) value` cast as is. As you noted, the DECIMAL type contract guarantees a `BigDecimal`, and the neighbouring cases use the same direct casts. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
