fatmanverse commented on PR #12803: URL: https://github.com/apache/seatunnel/pull/12803#issuecomment-6207001347
Thanks @ryanmeowy and @DanielLeens for the reviews. - N1: added a note to the PR description. On a target whose unique index treats NULLs as equal (for example SQL Server), the extra NULL-key rows now fail with a unique-constraint error, where before they were silently dropped. - N2 / ClickHouse: same pattern, confirmed in `ReduceBufferedBatchStatementExecutor`. To keep this PR scoped to Jdbc, I opened #12821 as a follow-up. - CI: `unit-test (11, ubuntu-latest)` failed in `SavePointTest.testSavePointButJobGoingToFail` (`seatunnel-engine-server`), which this PR does not touch. I re-ran the failed jobs. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
