SEZ9 commented on issue #11007: URL: https://github.com/apache/seatunnel/issues/11007#issuecomment-6206414292
@1328837476-hug, thanks for the follow-up and apologies for the delayed answer. I've gone through your updated PR description: the test mapping (valid / missing / empty / whitespace-only / padded URL), the short explanation of the EN/ZH doc changes, and the link back to this issue all line up with the HTTP Sink slice agreed here — `Conditions.notBlank(URL)` on the factory rule only, with URL parsing, placeholder handling, HTTP execution, retries, and runtime connectivity checks left untouched. Good to hear the Build check went green after the update as well. From the tracker side, that HTTP Sink URL row is now recorded as completed, so there is nothing further I need from you on it. The only ask is the usual one: please don't open a parallel change touching the same rule; if anything about the HTTP URL validation comes up later, raise it on this thread first so we can scope it before any new PR. Thanks for keeping the change narrow and well documented. <!-- streview-comment:1780 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
