SEZ9 commented on issue #12763:
URL: https://github.com/apache/seatunnel/issues/12763#issuecomment-6183886372

   Thanks @goutamadwant for reproducing this and laying out the plan — the 
four-PR split looks reasonable, with the Iceberg 1.10.2 upgrade, v3 table 
creation, `timestamp_ns`/`unknown` mapping and docs landing first in #12777, 
followed by deletion vectors, the remaining v3 types/row lineage/incremental 
reads, and multi-argument transforms.
   
   A couple of things that would help review of #12777:
   
   - Since the dependency bump touches `iceberg-hive-metastore`, `iceberg-aws`, 
`orc-core`, `parquet-avro` and `avro`, please note in the PR how you verified 
the shaded artifact and the existing v1/v2 e2e cases on the Zeta/Flink/Spark 
runners.
   - For the `timestamp_ns` / `unknown` mapping, a short note in the PR 
description on the chosen `SeaTunnelDataType` (and how 
`variant`/`geometry`/`geography` are handled until PR 3 — e.g. rejected with a 
clear error) would let reviewers agree on the conversion behavior up front.
   
   I'll take a look at #12777.
   
   <!-- streview-comment:1774 -->


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to