SEZ9 commented on issue #12612: URL: https://github.com/apache/seatunnel/issues/12612#issuecomment-6183055021
Thanks for circling back on this and checking the history first, @SEPURI-SAI-KRISHNA. Agreed: withdrawing the `COALESCE`/`IFNULL` issue is the right call. With #9295 asking for exactly that behaviour, #9299 implementing it, and `7f756b188` adding both the `coalesce(args, targetType)` overload in `SystemFunction` and the first-non-null walk in `ZetaSQLType`, "first argument wins" is the shipped contract. An issue proposing the widest-type rule would be a revert request rather than a bug report, so no separate issue is needed, and I'm happy to drop my earlier agreement that one was warranted. Both follow-ups look right to me: 1. `COALESCE(CAST(int_col AS BIGINT), bigint_col)` is the correct way to get the wider type, and it needs no code change. 2. Since the target type comes from the first argument, `COALESCE`/`IFNULL` is the route by which a value reaches a narrower integral target with no explicit cast, so that is where the range checks from #12605 and the `BIGINT` change will surface. Having both `incompatible-changes.md` entries call that out directly is exactly what I'd want to see. Everything else from your 2026-10-04 comment stands: the `BIGINT` PR stays sequenced behind #12605 so it can reuse `numberToInt`, `intFromExact` and `outOfIntRange` rather than adding a near-duplicate `outOfLongRange`, and it goes up once #12605 lands. Nothing further is needed from you on this issue until then. <!-- streview-comment:1758 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
