zhengxiang378928908-code commented on PR #12760: URL: https://github.com/apache/seatunnel/pull/12760#issuecomment-6182412018
Hi @Asthenia0412 @DanielLeens, following up on the overlap note. Both PRs now cover the same pieces for #12754: the IPV4/IPV6 → STRING mapping, the reconvert path, the `SchemaUtils` NPE on scan open, and the IPV4 Int32 conversion in `DorisValueReader`. Merging both doesn't make sense, so it would help to pick one. Where #12761 stands right now: DanielLeens's latest review says "Ready to merge", fork CI is green on head `2158f559`, and it has been checked end to end against a real Doris 4.0.6 cluster. It also has dedicated tests for the Arrow IPV4 path (`DorisValueReaderIpv4Test`) and for `SchemaUtils`. I'm happy with either outcome: - If the maintainers go with #12761, I'll add @Asthenia0412 as a co-author, since #12760 was opened first and we worked on this in parallel. - If they'd rather go with #12760, I'll close #12761 and can run it against my Doris 4.0.6 setup once CI is running. @davidzollo, could you let us know which you'd prefer? Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
