DanielLeens commented on PR #11684: URL: https://github.com/apache/seatunnel/pull/11684#issuecomment-6161487754
Thanks @zhengxiang378928908-code for the update. Quick follow-up so the earlier CI note on this PR does not mislead anyone. The CI fact I cited in my last review has changed. I previously reported that the fork run for head `e3f0032171` had a `timed_out` apache-side `Build` because `updated-modules-integration-test-part-7 (17)` was cancelled at the run time limit (a hung `FlussSinkIT` case unrelated to this diff). I rechecked fork run https://github.com/zhengxiang378928908-code/seatunnel/actions/runs/38409575004: attempt 2 is `completed` with conclusion `success`, and no job on the latest attempt is failed or cancelled, including the Dameng lanes. So from my side: there is no remaining code-side blocker on this head, and CI is green on the fork. My earlier "re-run failed jobs" suggestion no longer applies. The remaining gate is a committer with write access, who can dismiss the old `changes requested` entry and approve. As a read-only reviewer I cannot do that step myself, so please keep the ping to `@davidzollo`. This is a static review of the diff and the fork run results; I did not execute the PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
