SEZ9 commented on PR #11559:
URL: https://github.com/apache/seatunnel/pull/11559#issuecomment-6160534638

   Thanks for the follow-up on `PR11559-F1` and for posting the links to the 
`KafkaSourceReaderGateTest` job results for head `522bedc2d25` (jobs 
113264137851 and 113264137976 on run 37762854171).
   
   I cannot confirm the finding resolved from comment text alone, so a couple 
of asks before I close it:
   
   1. Please point me to the diff on `522bedc2d25` showing the 
`deserializeSplit` visibility change and the two rejection tests 
(`productionDeserializeSplitShouldRejectClassOutsideAllowlist` and 
`productionDeserializeSplitShouldRejectSamePackageSubclassOutsideAllowlist`), 
so the test coverage you describe can be verified against the code rather than 
the description.
   2. If the test class or the production code changes again after 
`522bedc2d25`, please re-link the `KafkaSourceReaderGateTest` job results for 
the new head so the evidence stays tied to what gets merged.
   
   Once I have looked at the diff alongside the linked job output, I will 
update the status of `PR11559-F1` here.
   
   <!-- streview-comment:1749 -->


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to