zhengxiang378928908-code commented on PR #12761: URL: https://github.com/apache/seatunnel/pull/12761#issuecomment-6158449628
Thanks @DanielLeens for the review! - Issue 1: added `testConvertIpv4ReadFromArrowInt32` (2158f5596). It builds an Arrow stream in the shape Doris BE sends (`v4` as `Int(32, true)`, `v6` as `Utf8`, plus a `NULL` row), reads it with `ArrowToSeatunnelRowReader` into the STRING row type, asserts that the `v4` value comes out as an `Integer`, and then applies `convertIpv4Fields`. So the assumption that IPV4 reaches `next()` as an integer is now pinned by a test. The call in `next()` itself still needs a BE to exercise; that part is covered by the real-cluster check in the description. - Issue 2: switched the test helper to a normal import and added Javadoc to `ipv4FieldIndexes` and `convertIpv4Fields`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
