li3zhi4 commented on PR #11746: URL: https://github.com/apache/seatunnel/pull/11746#issuecomment-6144509659
@DanielLeens @SEZ9 — the remaining source-level items from review 5497365244 are implemented and pushed on `0d14a5669f`. **Issue 1: enforced SQL Server version fallback.** `SqlServerDialect.supportCompositeKeySplit(DatabaseMetaData)` now requires database major version >=11 (SQL Server 2012). An older version or a metadata-read SQLException returns false with an actionable WARN, retaining the existing single-column fallback. Tests explicitly assert 10=false, 11=true, 16=true and metadata failure=false; SQL Server was removed from the version-independent group. EN/ZH JDBC and incompatible-changes docs now distinguish the runtime version gate from the documented compatibility-level >=110 prerequisite (the compatibility level is not queried by this gate). **Issue 2:** the OceanBase sampling Javadoc is again attached to `supportsSamplingSharding()`, and `DatabaseMetaData` is imported normally. **Issue 4:** verified the parent chain: `sqlite.version` is defined only in the connector child POM and is not inherited by E2E part-3. Kept the matching 3.39.3.0 pin and the explicit keep-in-sync comment, as permitted in your review, rather than introducing an unrelated POM hierarchy change. Validation on the pushed implementation: CompositeKeyChunkSplitterTest 24/24, DynamicChunkSplitterTest 12/12, SqlWhereConditionHelperTest 118/118 — **154/154, zero failures/errors/skips**. Connector and E2E part-3 Spotless passed. Official JdbcSqlServerSplitIT ran against a real SQL Server Testcontainers service: **2/2, zero failures/errors/skips**, Maven BUILD SUCCESS. Diff check is clean. New head CI is created and queued: https://github.com/li3zhi4/seatunnel/actions/runs/38389796641 . This supersedes the earlier-head run; it is not yet green. Please perform the final review on `0d14a5669f` once the relevant checks are available. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
