li3zhi4 commented on PR #11885: URL: https://github.com/apache/seatunnel/pull/11885#issuecomment-6144040480
Thanks @SEZ9 \u2014 I rechecked the exact current head `7f17332b7a` and mapped all five points below.\n\n- **F1/F6 \u2014 checkpoint persistence and legacy fallback:** `IncrementalPhaseState.java:24-52` contains the unchanged `serialVersionUID`, `stopOffset` field and constructors; `IncrementalSplitAssigner.java:114-125` restores state, `:202-219` adopts the in-flight/legacy split fallback, and `:225-227` writes the checkpoint state. The real Java serialization round-trip and legacy-null tests are `IncrementalPhaseStateTest.java:32-73`; the assigner fallback coverage is `IncrementalSplitAssignerTest.java:200-236`.\n- **F2 \u2014 one authoritative stop boundary:** the single `resolvedStopOffset == null` guard and reuse are in `IncrementalSplitAssigner.java:323-351`; `HybridSplitAssigner.java:99-117` only enters incremental allocation after snapshot completion. Resolve-once/reuse-after-restore coverage is `IncrementalSplitAssignerTest.java:157-197`.\n- **F3 \u2014 readiness gate:** `MysqlCDCStopModeSpecificIT.java:340-423` waits for row 1, asserts row 2000 is not visible while the snapshot is still active, and only then performs the post-snapshot update/assertion at `:425-449`; `mysqlcdc_stop_mode_latest.conf:18-40` sets `snapshot.split.size=20`.\n- **F5 \u2014 bounded retry:** `IncrementalSplitAssigner.java:379-414` performs three total attempts with 300ms then 600ms backoff and preserves interruption.\n- **F4/F7/F8 \u2014 docs/description:** the EN MySQL CDC semantics are at `docs/en/connectors/source/MySQL-CDC.md:203` and `:544-548`; the matching ZH sections are at `docs/zh/connectors/source/MySQL-CDC.md:202` and `:536-539`. The current PR description matches the enumerator-side, post-snapshot, checkpointed resolution and the `initial` E2E scope.\n\nThe PR body checkboxes are all checked. I found no missing implementation item; the remaining gate is the current Build/approval process, not a source-level issue.\n -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
