DanielLeens commented on PR #12081: URL: https://github.com/apache/seatunnel/pull/12081#issuecomment-6116669533
@SEZ9 on the F4 test request: it is already in the PR at the current head `ab04db33a`. `WALWorkHandlerSurvivabilityTest` (the APPEND write-failure case, around L140-185) drives one failing APPEND through `handler.onEvent(...)` and asserts three things. The first future completes with `false` and `onEvent` does not throw. A second APPEND also completes with `false`. The writer is invoked exactly once (`writeCalls == 1` and `verify(failingWriter, times(1)).write(...)`). It also asserts `isAppendBlockedAfterWriteFailure()` stays true. If the sticky flag were removed from `WALWorkHandler`, the second APPEND would call the writer again and the `times(1)` check would fail, so the test can detect a regression. So I don't think a new test is needed there. Please confirm against the diff when you get to it. Thanks both for the careful follow-through. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
