det101 commented on PR #12545:
URL: https://github.com/apache/seatunnel/pull/12545#issuecomment-6116165612
Thanks @DanielLeens. Pushed a follow-up that covers the remaining items and
is rebased onto current `dev`:
1. **High — prefixed credential keys.** `CRED_KV_RE` / the unquoted matcher
now use `(?<![A-Za-z0-9])`, so `jdbc_password`, `s3_secret_key`,
`access_token`, `truststore_password` and `api_token` are swapped before the
LLM call and redacted in debug output. `${...}` placeholders are still left
intact. Covered by redaction and replace/restore tests.
2. **Medium — `phase2=` summary.** `format_debug_line` runs string fields
through `first_line_reason` (redact + single line). The snippet path was
already redacted.
3. **Merge conflict.** Rebased onto latest `dev`. The only textual conflict
was `cli.py`: kept dev's `_build_failure_report` and left credential
replacement on the shared `credentials.py` helpers.
Local: `ruff check` clean, `python -m pytest tests` → 272 passed.
Please take another look.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
