chovy-3012 commented on PR #12703: URL: https://github.com/apache/seatunnel/pull/12703#issuecomment-6115298114
Thanks for the thorough second round. Both items are addressed in `3df0352b9`: **Issue 1 (cache cap):** `FORMATTER_CACHE` is now bounded to 1024 entries via a `size()` check before `putIfAbsent`. Beyond the cap, a fresh uncached formatter is returned, preventing unbounded growth from per-row pattern columns. **Issue 2 (test split):** `testUnixTimestamp()` is split into 7 focused `@Test` methods (no-arg, string patterns, null/invalid, typed inputs, non-UTC zone, clamping). Also added `testFromUnixTimeUnixTimestampRoundTrip` — a unit-level `FROM_UNIXTIME(UNIX_TIMESTAMP(s))` round trip under `Asia/Shanghai`. All 22 unit tests pass; spotless clean. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
