SEZ9 commented on PR #11307:
URL: https://github.com/apache/seatunnel/pull/11307#issuecomment-6104888656
Thanks for syncing with `dev`. Comparing the new head `d55343e8cb` with
`b1718c2301`, the PR's own change is unchanged and the merge resolution looks
correct, so I have no new findings. The earlier non-blocking items carry over
unchanged on this head:
- **Windows launcher** (`start-seatunnel-spark-3.5-connector-v2.cmd`):
`setlocal disabledelayedexpansion` is issued before `!errorlevel!`/`!CMD!` are
expanded, so the branches compare literal strings and `call` targets the
literal text `!CMD!`. Also, when the starter java process fails with no stdout
the script exits 0, since `for /f` hides java's real exit code.
- **Shell launcher** (`start-seatunnel-spark-3.5-connector-v2.sh`): the
command line passed to `eval` is assembled from job-config values, which allows
shell injection via config-controlled content. Unquoted `args=$@`, `${args}`
and `${CLASS_PATH}` are also subject to word-splitting and glob expansion.
- **Logging bindings** (`seatunnel-core/seatunnel-spark-starter/pom.xml`):
both `log4j-slf4j-impl` and the new `log4j-slf4j2-impl` are in the logging jar
include list, while both launchers put `starter/logging/*` on the classpath,
risking dual-binding conflicts.
- **Translation layer** (`seatunnel-spark-3.5-starter/pom.xml`): the starter
shades `seatunnel-translation-spark-3.3`, compiled against Spark 3.3.0, so a
Catalyst binary mismatch would only surface at runtime as `NoSuchMethodError`.
- **Tests**: the docs point Spark 3.5 users at the streaming template, but
the new 3.5 tests cover only the row encoder and batch write; the micro-batch
streaming path is unverified on 3.5.8.
- **Docs** (`docs/en/engines/spark.md`): narrowing
`seatunnel-spark-3-starter.jar` to "Spark 3.3.x" leaves Spark 3.4.x users
without guidance.
None of these are blocking from my side; happy to take another look if you
decide to address any of them.
<!-- streview-comment:1667 -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
