DanielLeens commented on issue #12677:
URL: https://github.com/apache/seatunnel/issues/12677#issuecomment-6059628930

   Classification: A / Zeta checkpoint-storage retention.
   
   The report is confirmed on current dev: `completePendingCheckpoint` allows 
the deque and backing storage to grow beyond the documented `max-retained` 
value, and the existing retention IT currently encodes the old `2 * 
max-retained` behavior.
   
   There are already two exact active implementation PRs: #12678 (created 
first; Build currently succeeds) and #12681 (Build currently fails). Please do 
not open a third PR or change labels/assignees for this issue. The contributors 
should converge on one implementation through those PR threads.
   
   Neither is ready to merge. #12678 changes storage-delete failure semantics 
by swallowing `CheckpointStorageException` after the checkpoint is stored; that 
is a separate behavior decision and needs explicit restore/error-path 
justification rather than being folded into this bound fix. #12681 is not a 
viable alternative while its Build fails. The retained-id assertion should 
prove the coordinator is at or below the configured bound after 
`completePendingCheckpoint` returns, and the storage test should verify the 
stable post-prune result rather than redefining the retention contract.
   
   The configuration name and default stay unchanged. No label or assignment 
changed in this pass.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to