hutiefang76 commented on PR #12443:
URL: https://github.com/apache/seatunnel/pull/12443#issuecomment-5985667770
> F5: Could you confirm that in the PR description?
> F3 / F6: ... a key containing `->`, ... embedded quotes/backslashes, ...
`$` or `:`?
> F4: ... an `RestApiIT` case ... or ...
`RestApiSubmitJobConfigShadeDecryptTest` ...?
Confirmed against 971fb98587b1:
- F5/F7: the description explicitly identifies the shared API utility and
its ConfigBuilder, ConfigShadeUtils and ReadonlyConfig callers. RestUtil has no
one-off guard. The changed production modules are seatunnel-api and
seatunnel-core-starter, so the title remains [Fix][Core].
MetadataProviderManager and AssertSink are explicitly left out of scope.
- F3/F6: `RestUtilTest#buildConfigShouldKeepValidPathExpressions` asserts
`a->b` becomes a nested config;
`buildConfigShouldPreserveEscapedAndReservedKeysThroughConfigShade` asserts
standalone `$`, `:`, `${FOO}` and quote/backslash keys after encrypt + decrypt.
`ConfigBuilderTest#testInvalidPathKeysSurviveConfigShadeRoundTrip` covers the
shared decrypt path with the regex and escaped/reserved keys. Successfully
parsed keys still undergo the existing quote/whitespace normalization; that
pre-existing behavior is accepted and outside this fix, as the description now
states.
- F2: the matching key-semantics note is present in both docs/en and
docs/zh/engines/zeta/rest-api-v2.md.
- F4: `RestApiIT#testSubmitJobWithJsonFormat` contains a top-level regex
key. The nested field path is covered by
`RestApiSubmitJobConfigShadeDecryptTest#testSubmitJobWithRegexFieldInJson`
against the actual /submit-job HTTP endpoint. The description records the local
E2E fat-jar limitation, so it does not claim a nested-key E2E result.
These are confirmations of the existing current-head code and recorded
validation; I have not run those SeaTunnel tests again in this pass. Remote CI
still needs a fresh result before merge.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
