SEZ9 commented on PR #12251: URL: https://github.com/apache/seatunnel/pull/12251#issuecomment-5771185165
Thanks @goutamadwant. `cba69e7ce` on top of `74defe3d5` already covers the conversion-path changes I went through in my last pass (fail-closed cause-chain whitelist, rethrowing `Error`, and conversion diagnostics carrying no record/value/path/cause), so nothing further is needed from you on those. For the EN/ZH documentation and compatibility-note follow-up you describe (path exception now attached as the cause, plus the stack-trace section), I don't see a commit referenced in this thread yet. Could you point me to it? Once I can look at the diff I'll check it against the remaining points from my earlier review myself — `ROUTE_TO_TABLE` handling on the conversion-error path, the `row_error_handle_way` and "Configure error data handle way" sections, the compatibility note for the default `FAIL` behaviour, the test overlap/reflection, and how the cause is attached — rather than asking you to confirm each one. Happy to take another pass as soon as it's up. <!-- streview-comment:1235 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
