nzw921rx commented on PR #12418: URL: https://github.com/apache/seatunnel/pull/12418#issuecomment-5777171649
@Vivek1106-04 Here are my views. If you have any different opinions, you can correct them 1. Thank you for pointing out this gap. I think this can actually be handled directly in your PR by modifying the JMH `setup()` method to initialize a `CheckpointManager`. Then the coordinator can obtain the real scheduler through: ```java this.scheduler = manager.leaseCheckpointScheduler(pipelineId); ``` 2. Regarding `coordinatorConfig.getCheckpointInterval()`: what if we reduce it enough, for example to `0`, so that it does not create a scheduling loop and every benchmark invocation is triggered explicitly by JMH? I am not sure whether this is feasible, but I think it is worth checking. 3. I agree with your point. 4. Between the two approaches, I prefer building a real in-memory `IMap` implementation. 5. I do not think we need to start a real SeaTunnel engine. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
