hutiefang76 opened a new pull request, #12443:
URL: https://github.com/apache/seatunnel/pull/12443

   ### Purpose of this pull request
   
   Fixes #12434.
   
   REST job submission converts a JSON body to a Java map before handing it to 
Typesafe Config. JSON keys such as `^t_nova_.*$` are literal field names but 
are rejected as invalid HOCON paths during `ConfigFactory.parseMap`. This 
change quotes only map keys that cannot be parsed as HOCON paths at the REST 
boundary, recursively including nested objects and list elements. Valid keys, 
including existing dotted option keys, retain their current behavior; 
config-file and HOCON submission paths are unchanged.
   
   ### Does this PR introduce _any_ user-facing change?
   
   Yes. Single and batch REST JSON job submissions can now include literal 
option keys with regular-expression characters, including nested connector 
configuration.
   
   ### How was this patch tested?
   
   - Added REST utility tests for single and batch JSON submission with a 
nested `^t_nova_.*$` key.
   - Added coverage confirming the existing `shade.identifier` literal key 
remains available to config-shade decryption and sensitive values still decode 
correctly.
   - 
`JAVA_HOME=/Users/hutiefang/Library/Java/JavaVirtualMachines/ms-17.0.18/Contents/Home
 PATH="$JAVA_HOME/bin:$PATH" ./mvnw -pl 
seatunnel-engine/seatunnel-engine-server -am -pl 
'!seatunnel-config/seatunnel-config-shade,!seatunnel-config/seatunnel-config-base'
 -Dtest=RestUtilTest -Dsurefire.failIfNoSpecifiedTests=false test` completed 
successfully. The 38-module dependency build passed and `RestUtilTest` ran 3 
tests with no failures or errors.
   - `git diff --check` passed.
   
   This change was prepared with OpenAI Codex assistance. Please review the 
code and validation evidence through the normal project process.
   
   ### Check list
   
   * [ ] No new Jar binary package is added.
   * [ ] No documentation update is needed because this restores the existing 
REST JSON literal-key behavior.
   * [ ] No incompatible change is introduced.
   * [x] REST utility tests cover single submission, batch submission, and 
config-shade compatibility.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to