SEZ9 commented on issue #12407: URL: https://github.com/apache/seatunnel/issues/12407#issuecomment-5771146218
Thanks for the detailed proposal. Since this touches public SPI, ciphertext layout and packaging, please open a design doc / discussion on the dev@ mailing list before implementation so the KeyProvider and DataCipher interfaces, versioning of the ciphertext format, and module layout (seatunnel-transforms-v2 core vs. optional provider modules) can be agreed on first. Please clarify the backward-compatibility guarantee: existing jobs using a static `key` with AES-CBC/AES-GCM must keep working unchanged, and data already encrypted by the current implementation should remain decryptable. It would help to spell out how the new ciphertext layout (e.g. key-version/provider metadata header) is distinguished from legacy ciphertext. Suggest splitting delivery into incremental PRs: (1) SPI + refactor of existing static-key path with tests, (2) one reference provider (e.g. HashiCorp Vault or AWS KMS) with e2e tests, (3) remaining providers. Please also state how key caching/rotation and provider initialization failures are handled at job start versus per-record. <!-- streview-comment:1234 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
