wgzhao commented on PR #12333: URL: https://github.com/apache/seatunnel/pull/12333#issuecomment-5706569315
Thanks for the approval, and for catching both of those - both are fixed in `0dfcce388`. - **Issue 1**: the case now uses the inherited `connection` field, the same one every other DDL helper in this class uses, instead of opening a second socket to the container mid-class. - **Issue 2**: the `DROP TABLE` moved into a `finally`, so cleanup no longer depends on all four assertions passing. ## One thing about the CI signal on the previous head Worth flagging, because it changes how much the red `Build` on `a8a0963d` actually tells us. The run failed in `PostgresCDCIT` (`testPostgresCdcSnapshotOnlyAndCommittedOffsetStartupModes`, ~1395s, `ConditionTimeoutException`) and `OpengaussCDCIT` - the same container flakes you diagnosed - but as a consequence the JDBC lanes never executed at all. `jdbc-connectors-it-part-1` and its siblings (`-part-2` ... `-part-7`, `-ddl`) came back **skipped**, not passed, and `unit-test (11, windows-latest)` failed as well. For reference, the rest of that run was healthy: 40 jobs succeeded, including `mysql-cdc-connector-it`, `unit-test (8, ...)` on both ubuntu and windows, and the code style / license / sanity checks. So the new `JdbcMysqlIT` case has not actually been exercised in CI yet, which is exactly the confirmation you asked for before merge. This push starts a fresh full run rather than a re-run of the failed jobs, so `jdbc-connectors-it-part-1` should execute this time. I will keep an eye on it and report back here if anything in the JDBC lanes turns red. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
