DanielLeens opened a new pull request, #11207:
URL: https://github.com/apache/seatunnel/pull/11207

   ## Why
   - `#11150` failed in shared CI because several E2E job configs still used 
JDBC URL shapes that no longer satisfy the runtime catalog validation path.
   - Oracle CDC configs used `jdbc:oracle:thin:@host:port/service`, but the 
failing path validated them through the generic `JdbcUrlUtil` parser, which 
requires the `//host:port/database` form.
   - SQLServer sink configs that enable catalog-based save mode still missed 
`databaseName`, so runtime validation aborted with `JDBC URL must contain a 
database name`.
   
   ## What changed
   - Normalize Oracle CDC E2E URLs to 
`jdbc:oracle:thin:@//oracle-host:1521/ORCLCDB` so the shared validation path 
can extract the default database.
   - Add `databaseName=...` to the affected SQLServer CDC/JDBC E2E sink URLs.
   - Add parser regression tests for the Oracle service-name URL shape and the 
simplified SQLServer `databaseName=...;encrypt=false;` shape.
   
   ## Validation
   - `./mvnw spotless:apply -pl 
seatunnel-e2e/seatunnel-connector-v2-e2e/connector-cdc-oracle-e2e,seatunnel-e2e/seatunnel-connector-v2-e2e/connector-cdc-sqlserver-e2e,seatunnel-e2e/seatunnel-connector-v2-e2e/connector-jdbc-e2e/connector-jdbc-e2e-part-3,seatunnel-e2e/seatunnel-connector-v2-e2e/connector-jdbc-e2e/connector-jdbc-e2e-ddl
 -nsu -Dmaven.gitcommitid.skip=true -T 3C`
   - `./mvnw -q -DskipTests verify -pl 
seatunnel-e2e/seatunnel-connector-v2-e2e/connector-cdc-oracle-e2e,seatunnel-e2e/seatunnel-connector-v2-e2e/connector-cdc-sqlserver-e2e,seatunnel-e2e/seatunnel-connector-v2-e2e/connector-jdbc-e2e/connector-jdbc-e2e-part-3,seatunnel-e2e/seatunnel-connector-v2-e2e/connector-jdbc-e2e/connector-jdbc-e2e-ddl
 -nsu -Dmaven.gitcommitid.skip=true -T 3C`
   - `./mvnw spotless:apply -pl 
seatunnel-common,seatunnel-connectors-v2/connector-jdbc -nsu 
-Dmaven.gitcommitid.skip=true -T 3C`
   - `./mvnw -pl seatunnel-common,seatunnel-connectors-v2/connector-jdbc 
-DskipIT=true -DskipUT=false -Dtest=JdbcUrlUtilTest,SqlServerURLParserTest test 
-nsu -Dmaven.gitcommitid.skip=true -T 3C`
   
   ## Validation scope not fully rerun locally
   - I attempted `./mvnw -pl 
seatunnel-e2e/seatunnel-connector-v2-e2e/connector-jdbc-e2e/connector-jdbc-e2e-part-3
 -DskipUT=true -DskipIT=false -Dit.test=JdbcSqlServerIT verify -nsu 
-Dmaven.gitcommitid.skip=true -T 3C`.
   - That run stalled during the first local pull of 
`mcr.microsoft.com/mssql/server:2022-latest`, so the full SQLServer 2022 
container path was not completed locally in this worktree.
   - No modules outside the touched parser tests and listed E2E resource 
modules were rerun.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to