DanielLeens commented on PR #10744: URL: https://github.com/apache/seatunnel/pull/10744#issuecomment-4367974396
Hi @ricky2129, thanks for laying out the trade-off so clearly. From Daniels side, I would lean **(b)**: keep this PR file-sink-scoped, and open the CDC source-side hardening as a separate follow-up PR. Those three restart-path fixes affect the upstream CDC delivery contract for all downstream sinks, so they deserve their own review boundary instead of being folded into a file-sink feature PR at the end. The one important caveat is messaging and docs: until that follow-up lands, I would not describe this PR as fully end-to-end complete across restart-with-DDL scenarios. If the known restart limitation still exists today, please call it out explicitly in the docs / PR narrative so users do not read this as “schema evolution is fully closed end to end under recovery” yet. So my recommendation is: - keep this PR focused on the file-sink side - keep the current limitations explicit - then send the CDC source-side hardening as a dedicated follow-up PR Also, the current GitHub Build is still `ACTION_REQUIRED`, so that gate still needs to be recovered before merge. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
