zooo-code commented on PR #10665: URL: https://github.com/apache/seatunnel/pull/10665#issuecomment-4149229188
> https://github.com/apache/seatunnel/blob/afb610e85ce81913397e9a1fc642ee796d8d3130/seatunnel-engine/seatunnel-engine-server/src/main/java/org/apache/seatunnel/engine/server/task/flow/SinkFlowLifeCycle.java#L124-L133 > > This part also seems to rely on index-based mapping between `getSinks().keySet()` and `sinkTables`. Would it make sense to add a public method to `MultiTableSink` to return the table mapping directly? @dybyte I've added a `getSinkTableMapping()` method to `MultiTableSink` and updated `SinkFlowLifeCycle` to use it, removing the index-based mapping. Also refactored `getSinkTables()` to delegate to `getSinkTableMapping()` to avoid duplicated logic. No tests were added since MultiTableSink requires MultiTableFactoryContext to instantiate, making unit testing impractical without heavy mocking. Happy to add if you think it's needed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
