zooo-code commented on PR #10639: URL: https://github.com/apache/seatunnel/pull/10639#issuecomment-4141885307
> Thanks for adding the Javadoc here. > > I recommend option A for the `supports()` documentation: please make the precondition explicit and document that `MultiTableSink` is expected to contain at least one sub-sink, rather than changing the runtime behavior in this PR. > > Right now the new Javadoc says the method returns an empty list when schema evolution is not supported, but with an empty `sinks` map the implementation would hit `sinks.entrySet().iterator().next()` first. Since this PR is documentation-only, keeping the logic unchanged and clarifying the contract is the safer approach. @davidzollo Thanks for the careful review! I have updated the Javadoc for supports() to explicitly state the precondition (that the sinks map must contain at least one entry) and kept the runtime behavior unchanged, as you recommended. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
